Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: restore error output when not all .title URLs could be fetched #2029

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Feb 25, 2021

Description

Tin. Goes slightly beyond the previous error messages with a special case for failing to fetch all URLs in a list of 2+. Fixes #1946.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make quality (I didn't touch anything covered by tests)
  • I have tested the functionality of the things this change touches

Slight improvement over the previous error, by handling the case where
NONE of the URLs can be fetched if more than one was given.
@dgw dgw added Low Priority Tweak Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Feb 25, 2021
@dgw dgw added this to the 7.1.0 milestone Feb 25, 2021
@dgw dgw requested a review from a team February 25, 2021 02:23
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat.

@dgw dgw merged commit 4639e00 into master Mar 23, 2021
@dgw dgw deleted the url-title-error-regression branch March 23, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Low Priority Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages were removed from .title command
2 participants