Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple instances with systemd, defaults to 'sopel' #1059

Closed
wants to merge 1 commit into from
Closed

Support multiple instances with systemd, defaults to 'sopel' #1059

wants to merge 1 commit into from

Conversation

TheReverend403
Copy link
Contributor

Usage: systemctl start sopel@sopel

@maxpowa maxpowa added the Tweak label Jun 21, 2016
@anarcat anarcat mentioned this pull request Aug 30, 2016
4 tasks
@maxpowa
Copy link
Contributor

maxpowa commented Sep 30, 2016

I don't have much experience with systemd, so it'd be great if someone with experience could review this.

@dgw dgw added this to the 7.0.0 milestone Mar 26, 2018
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I know of systemd, this is a straightforward change. The only concern I have is for existing users, who will have to be told to move their configuration from /etc/sopel.cfg to /etc/sopel/sopel.cfg. For all I know, systemd has a way to perform such a migration automatically; I haven't looked very hard yet. But whether it's addressed by the unit file itself or by a note in the changelog, it will have to be addressed (separately, because the source repo of this PR no longer exists).

@Exirel
Copy link
Contributor

Exirel commented Jan 12, 2019

Why not both?

We can keep sopel.service file, and provide a sopel@.service template unit file too for anyone who need/want one.

With a bit of documentation, I think this should be fine!

dgw added a commit that referenced this pull request Mar 3, 2019
The source fork no longer exists, so this was rebased & merged locally
to fix conflicts and address PR feedback.

GitHub may or may not recognize the PR as merged, because the commit
hash changed.
@dgw
Copy link
Member

dgw commented Mar 3, 2019

Decided to use a small part of my Sunday morning on fixing this up. Merged by f2838a0 in modified form, leaving the original sopel.service file alone. Unfortunately, modifying the PR means GitHub can't tell it was merged, so this will go into the log as "Closed" instead.

@dgw dgw closed this Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants