reload: fix shutdown routines not called on .reload #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
Bugfix
|
@Hanicef would you rebase this at some point? |
reload_module_tree() already calls shutdown methods, so calling bot._shutdown() before getting into that function is redundant. This is an artifact of my rebase, NOT Hanicef's original work (which happened before reload_module_tree() even existed).
|
I should definitely have changed the base branch first, then rebased after, but here we are. That just puts it on me to verify the tests locally on 6.6.x, before merging, since Travis ran against |
dgw
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1381,
.reloaddidn't call any shutdown methods. This pull request addresses this by simply calling the shutdown method(s) before unloading the resources.Fixes #1395