loader: test coverage #1424
Merged
loader: test coverage #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix CI build tomorrow, I forgot to check flake8, my bad! Edit: done! Resume testing... 😄 |
Exirel
force-pushed
the
coverage-sopel-loader
branch
2 times, most recently
from
38b9608 to
d6b5022
Compare
|
Just took a peek because I was curious (and noticed I hadn't labeled this yet). The most exciting thing I see is Coveralls' current check status: "Coverage increased (+1.06%) to 43.248%" 🎉 |
Closed
|
@dgw I need to check that. There are a lot of interesting things in there! |
Exirel
force-pushed
the
coverage-sopel-loader
branch
from
d6b5022 to
4300b06
Compare
Exirel
force-pushed
the
coverage-sopel-loader
branch
from
4300b06 to
4acb6b5
Compare
|
@dgw you can remove the WIP tag and have a look. I bet you can merge that one eyes closed. 😉 |
Exirel
force-pushed
the
coverage-sopel-loader
branch
from
0856072 to
c9b749b
Compare
dgw
requested changes
Jan 29, 2019
Tested cases: * test function has new attributes, * these attributes all have a default value, * test the `commands` and `nickname_commands` attribute, * test the `rule` attribute, * test the `event` atribute, Missing cases are: * doc, * and example. Still better than nothing!
Exirel
force-pushed
the
coverage-sopel-loader
branch
from
c9b749b to
ee32151
Compare
Should be better now @dgw and thanks for the review again! Edit: apparently not. I forgot something somewhere... :| |
The config's default value for "nick" could be changed, breaking any tests that rely on this value. To prevent that, the tmpconfig fixture now provides a test nick.
Exirel
force-pushed
the
coverage-sopel-loader
branch
from
ee32151 to
2895155
Compare
dgw
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sopel.loadermodule is responsible for loading Sopel Module (as in, "plugins" for Sopel), so it's quite critical.So I added unit-tests, and change as few code as possible.
There is one function that I didn't test, because I want to rework it later:
enumerate_modules. This function does too many things, and relies on too many global or hard-coded variables. This must be changed.So, for now, here is a good increase in coverage for the project.
Initial description: