modules: use @require_admin instead of if trigger.admin #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HumorBaby
reviewed
Jan 23, 2019
Exirel
force-pushed
the
decorator-is-admin
branch
from
219a413 to
0054382
Compare
Exirel
force-pushed
the
decorator-is-admin
branch
from
0054382 to
5aa70ae
Compare
|
Note: rebase to stay up-to-date with the master branch. @dgw this is a fairly small change, so it's perfect for a quick & easy merge. |
Exirel
force-pushed
the
decorator-is-admin
branch
from
5aa70ae to
9b86bfb
Compare
Exirel
force-pushed
the
decorator-is-admin
branch
2 times, most recently
from
13bfdb8 to
77f1720
Compare
Exirel
force-pushed
the
decorator-is-admin
branch
from
77f1720 to
0a3e3aa
Compare
dgw
approved these changes
Mar 5, 2019
Maybe eventually. 😉 |
|
In the distant future: Changes between 8.8.3 and 9.0.0
===============================
[...]
API changes
-----------
* `module.require_admin()` now takes an optional boolean argument `reply` (default `False`)
* This was added back in 7.0.0, but we forgot about it until now🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a decorator in
sopel.module.require_adminthat check fortrigger.admin, but it wasn't used everywhere!So I fixed this, and added a
reply=Falseoptional argument, that, whenTrue, usesbot.replyinstead ofbot.say.It's a very small improvement.