Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: include python version #1462

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

HumorBaby
Copy link
Contributor

Last unsolicited PR until I dig into .reload more, I PROMISE 😁

Sometimes I forget which version of python I am using 😅. Really though, this stemmed from testing issues/code across multiple versions of Python. I could quickly check the Sopel version from the bot, but not the python version it was running on. This commit simply appends the Python version to the .version response.

I don't think it shouldn't really be a security issue to show the Python version of the bot... right??

@HumorBaby
Copy link
Contributor Author

What'r the chances of that test failing for that reason..?! 😱 (Build #1470)

Sometimes I forget which version of python I am using :( Really though, this stemmed from testing issues/code across multiple versions of Python. I could _quickly_ check the Sopel version from the bot, but not the python version it was running on. This commit simply appends the Python version to the `.version` response. This will still be useful even after Sopel drops Python 2 compatibility.
@dgw
Copy link
Member

dgw commented Jan 29, 2019

Travis getting a connection reset by peer… that's a new one. (I kicked build 1470.1, though, so it doesn't show the error any more. Could have easily made the test pass without your force-push. 😸)

I'm torn between including this in 6.6.2 (already planned to fix a few small bugs that weren't fixed in 6.6.x yet) and waiting until 7. I don't want to start a 6.7.x branch, and I kinda think this small added feature is slightly past the intent of a patch release.

Of course it's mostly useful for testing the current version, so putting this on master and not releasing it until Sopel 7 is probably fine. That'll also give plenty of time for feedback about the alleged security risk of including the Python version. (People who think the Python version is a risk probably also think the Sopel version is a risk, so I bet they just disable this module anyway. 🤣)

@dgw dgw added this to the 7.0.0 milestone Jan 29, 2019
@dgw dgw merged commit bfb142b into sopel-irc:master Mar 7, 2019
@HumorBaby HumorBaby deleted the feat-show-python-version branch March 7, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants