use platform to check OS name instead of try, except #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
killed PR #1477 to PR from a different branch as well as squash the committs |
Exirel
approved these changes
Feb 15, 2019
dgw
previously requested changes
Feb 15, 2019
There was a problem hiding this comment.
First, the obligatory "squash your fixup commit" comment. 😸 (It also couldn't hurt to prefix your "real" commit message with run_script: . Putting the affected module/component first in the commit message helps with reviewing changes later, when preparing releases.)
I also left a pretty hefty suggestion on the actual warning message line. We might bikeshed it a bit, depending on how strongly each of us feels about the wording.
deathbybandaid
force-pushed
the
check_os
branch
from
b030217 to
2176496
Compare
deathbybandaid
force-pushed
the
check_os
branch
from
2176496 to
8042066
Compare
deathbybandaid
force-pushed
the
check_os
branch
from
8042066 to
eeb0d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.