admin: save configuration on .join/.part command #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
reviewed
Feb 28, 2019
dgw
changed the title
dgw
previously approved these changes
Feb 28, 2019
dgw
dismissed
their stale review
What looked like a straightforward patch turns out to have some nice bugs upon testing…
Exirel
force-pushed
the
admin-join-save
branch
from
641f1ec to
0d54cb1
Compare
|
@dgw the "save password" thing is fixed. One test failed because of some random error, unrelated. |
dgw
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Going to leave my test instance running for a bit before I finish testing for part messages (pretty sure the network I test on hides part/quit messages until the client has been connected for a while, to combat spam). But aside from those, this functionally checks out. 👍
Edit: Part messages tested fine, too.
|
Rebased upon master. @dgw merge when you want :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For good measure, I added a configuration save on the
partcommand too.Fixes #563