Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: test sopel.cli.run's subparsers options #1509

Merged
merged 6 commits into from
Mar 27, 2019
Merged

cli: test sopel.cli.run's subparsers options #1509

merged 6 commits into from
Mar 27, 2019

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Mar 20, 2019 •
edited
Loading

As @dgw told me when he merged #1493 subparsers should be tested, too. So here they are.

@Exirel Exirel added this to the 7.0.0 milestone Mar 20, 2019
@Exirel Exirel self-assigned this Mar 20, 2019
@Exirel Exirel requested a review from dgw March 20, 2019 18:35
dgw
dgw approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny how the low-priority PRs often end up being the easiest to review, innit?

@dgw dgw merged commit 2f67c35 into sopel-irc:master Mar 27, 2019
@Exirel Exirel deleted the sopel-cli-run-tests branch September 5, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees

@Exirel Exirel

Labels
Low Priority Tests
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw