url: Fix py2 compatibility in trim_url() #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2 doesn't like `thing is unicode`; it wants `thing == unicode`. Of course, it just works with regular str in both py2 and py3… Oh well. This is another find from @Exirel's overhaul of URL handling for 7.x. As long as I was touching the line anyway, I added parentheses to make the operator precedence explicit. Likely unnecessary, but probably easier to read by some small measure.
dgw
added
the
Bugfix
|
Fortunately, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2 doesn't like
thing is unicode; it wantsthing == unicode. Of course, it just works with regular str in both py2 and py3… Oh well.This is another find from @Exirel's overhaul of URL handling for 7.x.
As long as I was touching the line anyway, I added parentheses to make the operator precedence explicit. Likely unnecessary, but probably easier to read by some small measure. (@Exirel, if you don't think the added parens are useful, I can drop it from this PR so you don't have to mirror it in #1510. 😸)