ip: fix tests (again) #1523
Merged
ip: fix tests (again) #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dns.google is quite a catchy name, but our tests were failing because of this sudden (not that I know where they would announce it) change. On the plus side, we now have robust tests that should correctly handle both the old and new hostnames, and probably most potential future changes as well. And they're *actually* using regex syntax, unlike before with the unescaped brackets and pipes.
dgw
added
Tests
Bugfix
Exirel
approved these changes
Mar 27, 2019
|
It could be a while. Travis is super slow today due to some issues they're having (incident page), but we'll get this in when we can. Then I'll do a mid-stream merge to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dns.googleis quite a catchy name, but our tests were failing because of this sudden (not that I know where they would announce it) change.On the plus side, we now have robust tests that should correctly handle both the old and new hostnames, and probably most potential future changes as well. And they're actually using regex syntax, unlike before with the unescaped brackets and pipes.