core: fix broken interrupt handling (6.6.x) #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check to the `bot.quit` method to ensure that a socket exists before writing the `QUIT` message. This prevents the unhandled `AttributeError` that prevents a clean quit when the connection phase is interrupted
Because the `time.sleep` during the disconnect phase, the signal handling is thrown off and a new bot is spawned before the `bot.hasquit` flag can be checked. Add a check at the top of the loop to see if the `hasquit` flag was set during a disconnect. Fixes sopel-irc#1478
HumorBaby
changed the title
|
Uh, Travis, could you wake up and report the PR status please? 😦 |
dgw
approved these changes
Apr 4, 2019
There was a problem hiding this comment.
Travis eventually did wake up, but more importantly I had a chance to test this.
It seems to fix all the broken cases I found. I'll discuss what it doesn't fix (or more accurately, what other problems were revealed hiding behind what this fixed) in #1527 and/or #1478—stuff that we should fix in 7.x, but that I won't worry about for 6.x any more.
This was referenced Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1527, but for
6.6.xbranch