Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add bot.hostmask getter #1537

Merged
merged 1 commit into from
Apr 4, 2019
Merged

core: add bot.hostmask getter #1537

merged 1 commit into from
Apr 4, 2019

Conversation

HumorBaby
Copy link
Contributor

Adds shortcut for bot.users.get(bot.nick).hostmask.

Closes #1533.

@dgw dgw added this to the 7.0.0 milestone Apr 2, 2019
@dgw dgw added the Feature label Apr 2, 2019
@dgw dgw changed the base branch from 6.6.x to master April 2, 2019 21:38
@dgw dgw force-pushed the feat-bot-hostmask-getter branch from 3e11ea0 to cff09a3 Compare April 2, 2019 21:39
@dgw
Copy link
Member

dgw commented Apr 2, 2019

Since this adds to the API, I bumped it to master (for 7.x) instead of the next patch release for 6.6.x.

Rebased for you, since it was a really easy one.

@HumorBaby
Copy link
Contributor Author

Sounds good.

@HumorBaby HumorBaby force-pushed the feat-bot-hostmask-getter branch from cff09a3 to 22006a0 Compare April 3, 2019 03:03
@HumorBaby
Copy link
Contributor Author

bot.hostmask getter has been fortified according to discussions on IRC.

@deathbybandaid deathbybandaid mentioned this pull request Apr 3, 2019
Closed
Exirel
Exirel requested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but I think we misunderstood each other when I talked about exceptions.

sopel/bot.py Outdated Show resolved Hide resolved
@Exirel Exirel mentioned this pull request Apr 4, 2019
Merged
Exirel
Exirel reviewed Apr 4, 2019
View reviewed changes
sopel/bot.py Show resolved Hide resolved
@HumorBaby
feat: add bot.hostmask getter
940e60d 
Adds shortcut for `bot.users.get(bot.nick).hostmask`.

Closes sopel-irc#1533.
@HumorBaby HumorBaby force-pushed the feat-bot-hostmask-getter branch from f391c23 to 940e60d Compare April 4, 2019 13:17
dgw
dgw approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Exirel approve (or dismiss your old review) if all your concerns are handled. :)

@dgw dgw merged commit cf0177e into sopel-irc:master Apr 4, 2019
@HumorBaby HumorBaby deleted the feat-bot-hostmask-getter branch August 28, 2019 14:14
@dgw dgw mentioned this pull request Dec 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HumorBaby @dgw @Exirel