Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix _store() so it accepts any named arguments #1538

Merged
merged 1 commit into from
Apr 4, 2019
Merged

fix _store() so it accepts any named arguments #1538

merged 1 commit into from
Apr 4, 2019

Conversation

jbrunink
Copy link
Contributor

@jbrunink jbrunink commented Apr 2, 2019

New PR as I absolutely messed up the original one..

When running a testsuite where the bot.say, reply or action function has any other than the defined arguments set, for example max_arguments, it will fail. With this change it should accept any named arguments.

Would be nice if this could also be done for the 6.6.x branch.

TypeError: _store() got an unexpected keyword argument 'max_messages'

@dgw dgw mentioned this pull request Apr 2, 2019
Closed
@dgw dgw added this to the 6.6.6 milestone Apr 2, 2019
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Apr 2, 2019
dgw
dgw approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy approve, this.

@dgw dgw added the Tests label Apr 4, 2019
@dgw dgw merged commit 8aad940 into sopel-irc:6.6.x Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Tests
Projects
None yet
Milestone
6.6.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrunink @dgw