coretasks: Major rewrite of MODE handling #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
the
Bugfix
half-duplex
reviewed
Apr 27, 2019
It appears (as observed on a real bot in production) that batched MODE messages would trip up the old code and assign incorrect privilege bitmasks depending on the ordering and other factors. This rewrite is a first attempt at fixing that. Notably, it specifically bails out if something looks too complicated to parse. Co-authored-by: mal <mal@sec.gd>
dgw
force-pushed
the
mode-parsing-revisited
branch
from
520d2fd to
78b5878
Compare
Exirel
requested changes
Apr 27, 2019
There was a problem hiding this comment.
It's great to see a bug fix with some unit-tests! However, I'd like to prevent what I call the "too smart" syndrome.
Tests are dumb things, KISS and DRY are nice, but they mostly don't apply to them. I prefer a test that repeats itself than a test that, by being too smart or too clean, misses its target.
For instance, a SopelWrapper instance is never used multiple times for different Trigger: there is one and only one per Trigger. The same SopelWrapper can be used in multiple commands, but that's another thing!
Co-authored-by: Florian Strzelecki <florian.strzelecki@gmail.com>
half-duplex
force-pushed
the
mode-parsing-revisited
branch
from
a164bbc to
c651804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR early as a draft, to gather feedback from @half-duplex (who reported a possible mode-tracking bug in the 6.6.x series to me) and others who might have more spare time and/or brainpower this weekend than I seem to (so far). 😅
If this turns out to be a productive rewrite, it's a solid reason to release a version 6.6.7 (which is not currently planned). Should it not help anything, I mean what I said in that comment about rewriting the mode tracking again after ISUPPORT parsing (#1536) gets finalized and merged for Sopel 7.