admin: Also protect owner_account setting
#1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need a way for settings to declare themselves protected, or private, so the `admin` module doesn't have to hard-code handling for settings whose values shouldn't be displayed or changed on IRC.
dgw
added
Tweak
Bugfix
dgw
changed the title
owner_account setting, tooowner_account setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I hadn't rushed 6.6.8 out, this would have been fixed already, but I was too quick to approve and merge #1587 and didn't realize there was another setting that needed protection until it was too late.
I'm sure there will be more little things to fix, so I'm not gonna rush this one out. Very few networks actually support the IRCv3 capabilities Sopel needs to authenticate accounts, so it's not urgent.