tools: add optional arguments to deprecated, and deprecate Ddict #1613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, at first, I was going to deprecate the
Ddict
class, which can be replaced bycollections.defaultdict
since Python 2.5. I suspect it was very useful when the bot had to support Python version such as 2.2 or 2.4 (which used to be quite popular for a long time).However, I could not get the proper deprecation warning: decorating the
__init__
method didn't give me what I wanted.So I decided to allow this usage of the
@deprecated
decorator:So now,
Ddict
is deprecated, and we have a better decorator!