Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: example online argument defaults to False #1614

Merged
merged 1 commit into from
May 18, 2019
Merged

module: example online argument defaults to False #1614

merged 1 commit into from
May 18, 2019

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented May 18, 2019

I think I didn't rebase properly and set online=True by default instead of online=False on the example decorator in #1555

@Exirel Exirel added Tests Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels May 18, 2019
@Exirel Exirel added this to the 7.0.0 milestone May 18, 2019
@Exirel Exirel requested a review from dgw May 18, 2019 18:18
dgw
dgw approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a yikes

@dgw dgw merged commit 8d8f6be into sopel-irc:master May 18, 2019
@Exirel Exirel deleted the fix-example-online branch September 5, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Tests
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw