currency: switched crypto api and combined rates to allow cross-lookup #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also applies the same fix as #1627 |
Doing this negates the advantage of having three-way merges, lol. |
|
Well I'm a git noob and didn't know what to do :P I can remove it and force push if you want :) |
|
Might as well fix the style-checker error and the overlap with #1627 at the same time. |
Duckle29
force-pushed
the
combined_rate_list
branch
2 times, most recently
from
c888f36 to
34f40f5
Compare
Duckle29
force-pushed
the
combined_rate_list
branch
from
34f40f5 to
5f93ee2
Compare
dgw
approved these changes
Aug 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the fiat currency rates and the cryptocurrency rates into one global variable
ratesinstead of keeping the two separate.This was done to allow better cross-compatibility between the two sources, allowing one to look up a conversion from a currency in one table, to a currency in the other.
To do this, a change of API was also done, as the old API used a weird and inflexible way to look up conversions.
The code also changed some variable names that I didn't like. mostly the "of" and "to" variables were changed to base and target respectively.
This change also entirely eliminates the need for a separate crypto rates function.