bot: fix sometimes-undefined variable in flood protection #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `elapsed` was defined the same way in both places, there's no reason it can't be defined just once instead, in a higher scope that allows using it in loop detection also. The only stumbling block is the fact that the sensible default value for `elapsed` (0) would trigger logic that shouldn't be triggered. And we can't use the other sensible default (`None`) because you can't apply operations like `<` to `NoneType`. So I picked an arbitrary default.
dgw
added
High Priority
Bugfix
Exirel
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
elapsedwas defined the same way in both places, there's no reason it can't be defined just once instead, in a higher scope that allows using it in loop detection also.The only stumbling block is the fact that the sensible default value for
elapsed(0) would trigger logic that shouldn't be triggered. And we can't use the other sensible default (None) because you can't apply operations like<toNoneType. So I picked an arbitrary default.This is an important follow-up to #1518 and will bypass our general FIFO merge policy.