db: fix unicode on mysql

[RustyBower]

No description provided.

[deathbybandaid]

After some testing, I can confirm this clears issue #1650

[RustyBower]

I did just configure this for a single column in nick_values, but we should chat about all the potentially places people could put unicode characters and configure appropriately.

[deathbybandaid]

I would imagine this should be added to channel_values,, as well as the upcoming plugin_values in PR #1621

[dgw]

What @deathbybandaid said. Fixing this for only one DB column is no good; we need to allow Unicode pretty much anywhere there's a string/text. Some IRCds do in fact allow Unicode nicknames, for example.

[deathbybandaid]

Fresh database with mysql seems good with the __table_args__ setup.
I will try testing with sqlite and postgres later today.

I think those 3 databases are the only ones we should focus on. Any other database flavors can wait until people have issues with them.

[deathbybandaid]

Should we be concerned about line length with this?

[dgw]

@RustyBower Can we apply this also to all the tables it makes sense to? Channel names are very often Unicode-enabled even if nicknames aren't, for example.

I think we need this on almost everything:

• ChannelValues
• NickValues
• Nicknames

I guess NickIDs doesn't need it, because integers aren't strings. 😝

Alternatively, if you can set the default engine, charset, and collation for the whole database somehow, do that. 😈

[RustyBower]

Fixed the line length and additional table issues. I'll continue to do some research into defaulting this for the entire table.

[dgw]

Much ❤️ to @RustyBower for amending this so many times based on my feedback!

Because I've already asked him to force-push so many times, I'll ignore the somewhat unnecessary change to line-breaks in the URL() call. It's fine~!

[dgw]

(And I won't give Rusty time to "fix it anyway", either. 😈)

[Exirel]

Awesome fix! 👍