Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document tools.web package #1669

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Document tools.web package #1669

merged 2 commits into from
Oct 30, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Jul 26, 2019

Draft because it's based on the #1616 branch, which isn't yet merged.

See 6d53ced for the relevant changes. I'll keep an eye on this after merging its parent.

@dgw dgw added this to the 7.0.0 milestone Jul 26, 2019
@dgw dgw mentioned this pull request Jul 26, 2019
@dgw dgw force-pushed the docs-tools.web branch from 6d53ced to cd9feef Compare July 27, 2019 20:14
@dgw
Copy link
Member Author

dgw commented Jul 27, 2019

Poked it with a rebase just to be safe; GitHub appeared not to figure out the merge on its own.

@dgw dgw marked this pull request as ready for review July 27, 2019 20:15
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've some nitpick here and there but honestly I believe you can already merge as-is without a complain from me.

sopel/tools/web.py Outdated Show resolved Hide resolved
sopel/tools/web.py Show resolved Hide resolved
sopel/tools/web.py Outdated Show resolved Hide resolved
sopel/tools/web.py Outdated Show resolved Hide resolved
* Added `tools.web` to "Additional API features" page of docs
* Tweaked `tools.web` module header
* Wrote docstrings for everything in `tools.web`

Co-authored-by: Florian Strzelecki <florian.strzelecki@gmail.com>
@dgw dgw force-pushed the docs-tools.web branch from 94da9fd to ab07a6f Compare July 30, 2019 22:28
@dgw
Copy link
Member Author

dgw commented Jul 30, 2019

Nitpicks addressed. I'll consider this ready to merge now, barring any further nitpicks. 🚀

Copy over the same note from new `unquote()` function in #1681, and
tweak a word or two for consistency.
@dgw dgw merged commit e5ceb0d into master Oct 30, 2019
@dgw dgw deleted the docs-tools.web branch October 30, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants