bot: only suppress echo for PRIVMSG and NOTICE #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijseigenwijs reported that the bot doesn't update privilege tracking when it's the one to change a mode
dgw
reviewed
Jul 30, 2019
| is_echo_message = nick.lower() == self.nick.lower() | ||
| is_echo_message = ( | ||
| nick.lower() == self.nick.lower() and | ||
| event in ["PRIVMSG", "NOTICE"] |
There was a problem hiding this comment.
No need to wonder if the event will always be uppercase if you do this.
Suggested change
| event in ["PRIVMSG", "NOTICE"] | |
| event.upper() in ["PRIVMSG", "NOTICE"] |
But there's plenty of code already assuming these will always be uppercase, so it's probably not worth doing only here. (FWIW, most of that code seems to use 'single quotes', but that's also likely not worth changing here.)
Yes. |
dgw
added
Bugfix
dgw
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thijseigenwijs on IRC reported that the bot doesn't update privilege tracking when it's the one to change a mode. This is because the server's MODE message is ignored by the echo suppression. This PR changes the echo suppression to only suppress PRIVMSG and NOTICE events.