Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bot: fix arg order in say() recursion #1698

Closed
wants to merge 1 commit into from
Closed

bot: fix arg order in say() recursion #1698

wants to merge 1 commit into from

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 4, 2019 •
edited
Loading

Mixed up by @deathbybandaid in #1606. For shame that the rest of us missed it in code review, too!

Thanks to @cottongin for reporting.

@dgw
bot: fix arg order in say() recursion
357741d 
Mixed up by @deathbybandaid in #1606. For shame that the rest of us
missed it in code review, too!
@dgw dgw added High Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Oct 4, 2019
@dgw dgw added this to the 7.0.0 milestone Oct 4, 2019
@dgw dgw requested a review from a team October 4, 2019 21:35
@dgw
Copy link
Member Author

dgw commented Oct 24, 2019

Note: The very same bug is fixed in #1697's refactor. If that goes in soon, we don't need this.

@dgw dgw removed this from the 7.0.0 milestone Oct 24, 2019
@dgw dgw added the Replaced Superseded by a newer PR label Oct 24, 2019
@dgw dgw closed this Oct 24, 2019
@dgw dgw deleted the fix-bot.say-excess branch October 24, 2019 22:26
@dgw dgw removed the request for review from a team October 24, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) High Priority Replaced Superseded by a newer PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dgw