search: don't unquote DDG result #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
the
Bugfix
|
Another conflict! I believe this is also related to quote/unquote refactor, and nothing to worry about that much. |
Bing doesn't need it. Unquoting breaks URLs that contain spaces. This changed in #1265 but it's not clear why. As a bonus, we shed the entire block of py2/py3 shimming for `unquote`.
dgw
force-pushed
the
search-duck-whitespace
branch
from
b50550e to
5755921
Compare
|
Easy rebase. 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bing doesn't need it. Unquoting breaks URLs that contain spaces.
#1265 and associated changes later in the 6.x cycle introduced this unquoting, without any clear reason why. It doesn't appear to fix anything (not that my suite of test queries is that exhaustive).
As a bonus, we shed the entire block of py2/py3 shimming for
unquote.Also of note: This reduces the core plugin set's need for #1681, but it'll still be good to have.