Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add a default logging_format #1714

Merged
merged 2 commits into from
Oct 21, 2019
Merged

config: add a default logging_format #1714

merged 2 commits into from
Oct 21, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 21, 2019

Without this option specified, we get the Python default format, which is (among other problems) completely devoid of timestamp information.

This format, devised by @Exirel while refactoring the logging mechanism, outputs the timestamp, the package that generated the log line, the log level of the line, and (finally) the actual message.

We'll go from:

Registered 42 plugins, 0 failed, 0 disabled

to:

[2019-10-21 12:47:44,272] sopel.bot            INFO     - Registered 42 plugins, 0 failed, 0 disabled

Once this hits the stable release, it will become quite a bit easier to follow along with bug reports!

Without this option specified, we get the Python default format, which
is (among other problems) completely devoid of timestamp information.

This format, devised by Exirel while refactoring the logging mechanism,
outputs the timestamp, the package that generated the log line, the log
level of the line, and (finally) the actual message. Taking us from:

    Registered 42 plugins, 0 failed, 0 disabled

to:

    [2019-10-21 12:47:44,272] sopel.bot            INFO     - Registered 42 plugins, 0 failed, 0 disabled

Once this hits the stable release, it will become quite a bit easier to
follow along with bug reports!

Co-Authored-By: Exirel <florian.strzelecki@gmail.com>
@dgw dgw added the Tweak label Oct 21, 2019
@dgw dgw added this to the 7.0.0 milestone Oct 21, 2019
@dgw dgw requested a review from a team October 21, 2019 18:04
@Exirel
Copy link
Contributor

Exirel commented Oct 21, 2019

You might want to add that information to the documentation page!

@dgw
Copy link
Member Author

dgw commented Oct 21, 2019

Updating with more documentation. Rendered preview:

@dgw dgw merged commit 8548331 into master Oct 21, 2019
@dgw dgw deleted the time-in-default-logs branch October 21, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants