reddit: add comment handling #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
approved these changes
Oct 25, 2019
dgw
added a commit
that referenced
this pull request
Nov 23, 2019
This is a regular laundry list, honestly. * `post_url` was end-anchored to prevent matching the same links as `comment_url`, but didn't allow for the `/post_title_slug/` usually included after the submission ID. * `comment_url` & `post_url` used `.*` where they should have had `\S+` (whitespace is never present in reddit URLs, nor will any compenent of the link ever contain zero characters). * `user_url` unnecessarily captured "ser" (or "") as group 1. * So many unescaped `.`s everywhere! Fixes post links failing to match and falling back to `url.py` title fetching, and possibly some other silly bugs. I take full responsibility for breaking `post_url` in #1720. Whoops.
dgw
added a commit
that referenced
this pull request
Nov 23, 2019
This is a regular laundry list, honestly. * `post_url` was end-anchored to prevent matching the same links as `comment_url`, but didn't allow for the `/post_title_slug/` usually included after the submission ID. * `comment_url` & `post_url` used `.*` where they should have had `\S+` (whitespace is never present in reddit URLs, nor will any compenent of the link ever contain zero characters). * `user_url` unnecessarily captured "ser" (or "") as group 1. * So many unescaped `.`s everywhere! Fixes post links failing to match and falling back to `url.py` title fetching, and possibly some other silly bugs. I take full responsibility for breaking `post_url` in #1720. Whoops.
dgw
added a commit
that referenced
this pull request
Nov 23, 2019
This is a regular laundry list, honestly. * `post_url` was end-anchored to prevent matching the same links as `comment_url`, but didn't allow for the `/post_title_slug/` usually included after the submission ID. * `comment_url` & `post_url` used `.*` where they should have had `\S+` (whitespace is never present in reddit URLs, nor will any compenent of the link ever contain zero characters). * `user_url` unnecessarily captured "ser" (or "") as group 1. * So many unescaped `.`s everywhere! Fixes post links failing to match and falling back to `url.py` title fetching, and possibly some other silly bugs. I take full responsibility for breaking `post_url` in #1720. Whoops. Also adds error handling in `video_info()`, in case the hacky hack it uses to get the post URL fails. The errors I saw in testing that led to this whole patch were probably just because the `post_url` pattern was broken (see above), but... why not handle the error case anyway?
dgw
added a commit
that referenced
this pull request
Nov 23, 2019
This is a regular laundry list, honestly. * `post_url` was end-anchored to prevent matching the same links as `comment_url`, but didn't allow for the `/post_title_slug/` usually included after the submission ID. * `comment_url` & `post_url` used `.*` where they should have had `\S+` (whitespace is never present in reddit URLs, nor will any compenent of the link ever contain zero characters). * `user_url` unnecessarily captured "ser" (or "") as group 1. * So many unescaped `.`s everywhere! Fixes post links failing to match and falling back to `url.py` title fetching, and possibly some other silly bugs. I take full responsibility for breaking `post_url` in #1720. Whoops. Also adds error handling in `video_info()`, in case the hacky hack it uses to get the post URL fails. The errors I saw in testing that led to this whole patch were probably just because the `post_url` pattern was broken (see above), but... why not handle the error case anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got annoyed after pasting yet another Reddit comment link and seeing Sopel spit out the submission (link) info instead. This was something like a 15 minute project. Pretty easy. 😁