Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remind: fix default_timezone in .at command when tz not specified #1736

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Nov 8, 2019

With tz specified, it will be used if valid. If it's not valid, we fall back to either the user's default timezone (if set) or UTC (if not).

With tz not specified, this fixes UTC being used even if the user has a default timezone set.

Requesting @Exirel's review, as this directly relates to a previous patch of his (from #1590).

With tz specified, it will be used if valid. If it's not valid, we fall
back to either the user's default timezone (if set) or UTC (if not).

With tz not specified, this fixes UTC being used even if the user has a
default timezone set.
@dgw dgw added Medium Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Nov 8, 2019
@dgw dgw added this to the 7.0.0 milestone Nov 8, 2019
@dgw dgw requested a review from Exirel November 8, 2019 06:03
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Ok. I understand why you went for that or '' thing. Not particularly happy with that, but it does the job - also I don't have an alternative right now.

Quick note: could be merge with #1707 to check if everything's still fine.

@dgw dgw merged commit 42911e4 into master Nov 8, 2019
@dgw dgw deleted the at-command-tz-setting branch November 8, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Medium Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants