Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Fix plugin config duplicate y/n prompt #1739

Merged
merged 1 commit into from
Nov 24, 2019
Merged

cli: Fix plugin config duplicate y/n prompt #1739

merged 1 commit into from
Nov 24, 2019

Conversation

half-duplex
Copy link
Member

Was:

Would you like to see if there are any modules that need configuring (y/n)? [n] y
Configure safety.py - Alerts about malicious URLs (y/n)? [n] (y/n)? [n]

Now:

Would you like to see if there are any modules that need configuring (y/n)? [n] y
Configure safety.py - Alerts about malicious URLs (y/n)? [n]

@half-duplex half-duplex added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Nov 10, 2019
Exirel
Exirel approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(ignore Travis: random DDG failure)

dgw
dgw approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised @Exirel approved this without complaining that the quote style was switched. 😹

@Exirel
Copy link
Contributor

Exirel commented Nov 10, 2019

There are battles not worth winning.

@dgw
Copy link
Member

dgw commented Nov 10, 2019

It's all fun and games until someone enables flake8-quotes. 😆

@dgw dgw added this to the 7.0.0 milestone Nov 21, 2019
@half-duplex half-duplex force-pushed the configure-plugin-prompt branch from d0b0388 to 310e325 Compare November 24, 2019 02:35
@dgw dgw merged commit 5db2b5e into sopel-irc:master Nov 24, 2019
@half-duplex half-duplex deleted the configure-plugin-prompt branch November 25, 2019 04:00
@half-duplex half-duplex restored the configure-plugin-prompt branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Low Priority
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@half-duplex @Exirel @dgw