safety: rework cache cleanup logic #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, the old cleanup function was comparing timestamps the wrong way round, so it would end up deleting the NEWEST key. Second, it would only ever delete one cache key, regardless of how many entries over the limit the cache was. Now, we have an initial age-based cleanup that deletes all cache entries older than 7 days. If the cache is still over 512 entries, the oldest n entries are removed, where n is (cache_size - cache_limit). The daily cleanup schedule is still used. The cache cleanup now targets 512 entries instead of 1024, but a "cache too large" cleanup will still trigger only if the cache reaches 1024 items (twice the target size) to keep from triggering the relatively more expensive cleanup function for minor removals of just one or two entries. There is also now a lock to prevent running more than one simultaneous cleanup function call.
dgw
added
Medium Priority
Bugfix
Exirel
requested changes
Nov 19, 2019
Exirel
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the commit message, but the gist is implementing exactly what I described previously. This resolves #1572, assuming I haven't made any silly mistakes.