db: properly handling threaded sessions #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
previously approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Quick look around for tips and this seems like such a no-brainer now. A Sopel command running is conceptually the same as a web request; can't believe I didn't see it before.
dgw
added
Bugfix
|
@deathbybandaid Want to stress-test this a bit before I merge it? |
dgw
dismissed
their stale review
Not actually ready to merge without clarifying why the patch doesn't call .remove() on function-local session variables.
This comment has been minimized.
This comment has been minimized.
dgw
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
@RustyBower sorry for the noise, I should know by now not to look at DB stuff while half-asleep. 🙄
|
All good! Happy to help with any DB related things :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the errors @deathbybandaid was seeing in #1639