Prepare Sopel to adapt its output when py2 officially dies #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kind of magic-number-y, but I'd rather this than duplicating `datetime` code in two places. No, I do not feel like optimizing this out into a function that we'll remove as soon as we start on 8.0.
half-duplex
approved these changes
Nov 24, 2019
|
You could also just write "Python 2 will stop receiving updates on 1 Jan 2020. Sopel will stop supporting it in 8.0" and skip the dependency and magic. |
|
@half-duplex but I like magic 😝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of magic-number-y, but I'd rather this than duplicating
datetimecode in two places.No, I do not feel like optimizing this out into a function that we'll remove as soon as we start on 8.0.