Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: docstring overhaul & modernization #1770

Merged
merged 1 commit into from
Dec 17, 2019
Merged

module: docstring overhaul & modernization #1770

merged 1 commit into from
Dec 17, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Nov 30, 2019

Part of the ongoing effort to standardize (as best we can) Sopel's docstring formatting and make use of Sphinx features to enhance the public API documentation site. See #1565.

I blame @deathbybandaid for reminding me earlier this week that @action_commands didn't have a note in the docs about its current mutual exclusivity with the other command decorators. 😝

@dgw dgw added this to the 7.0.0 milestone Nov 30, 2019
@dgw dgw requested a review from a team November 30, 2019 07:09
@dgw dgw force-pushed the module-doc-overhaul branch from c97fb96 to 6dd12e5 Compare December 1, 2019 17:37
@dgw
Copy link
Member Author

dgw commented Dec 1, 2019

Can't believe I missed one little change. Had to fix, or Sphinx throws errors when building docs.

Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd need to build the doc to see the details, but I trust you on that. Beside, the next preview or when it's merged, I'll probably do a round of check anyway. I'm not worried.

Great job. 👍

Part of the ongoing effort to standardize (as best we can) Sopel's
docstring formatting and make use of Sphinx features to enhance the
public API documentation site. See #1565.
@dgw dgw force-pushed the module-doc-overhaul branch from 6dd12e5 to 8092b61 Compare December 3, 2019 20:14
@dgw
Copy link
Member Author

dgw commented Dec 3, 2019

@Exirel I just updated this with small consistency tweaks, but I don't think you need to re-review. 🙌

@dgw dgw merged commit c5516a7 into master Dec 17, 2019
@dgw dgw deleted the module-doc-overhaul branch December 17, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants