Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db, docs: overhaul docstrings & add SQLAlchemy to intersphinx mappings #1776

Merged
merged 1 commit into from
Dec 21, 2019
Merged

db, docs: overhaul docstrings & add SQLAlchemy to intersphinx mappings #1776

merged 1 commit into from
Dec 21, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Dec 6, 2019

Some of the stuff in SopelDB needed to reference SQLAlchemy docs, and adding those intersphinx mappings was trivially easy, so it was done.

@dgw dgw added this to the 7.0.0 milestone Dec 6, 2019
@dgw dgw requested a review from a team December 6, 2019 07:41
This was referenced Dec 6, 2019
Closed
Merged
Exirel
Exirel requested changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks to fix before approval. Still an impressive good job. 👍

sopel/db.py Outdated Show resolved Hide resolved
sopel/db.py Outdated Show resolved Hide resolved
sopel/db.py Outdated Show resolved Hide resolved
sopel/db.py Outdated Show resolved Hide resolved
sopel/db.py Outdated Show resolved Hide resolved
sopel/db.py Show resolved Hide resolved
@dgw dgw force-pushed the db-doc-overhaul branch 2 times, most recently from 75d2766 to 13c8c2f Compare December 9, 2019 07:00
@dgw
Copy link
Member Author

dgw commented Dec 9, 2019

@Exirel It's pretty easy to see exactly what I changed in response to your review here.

(Then I rebased in a separate force-push, because #1774 happened and Git couldn't figure out how to handle that one-line change itself. 😁)

Exirel
Exirel approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dgw
db, docs: overhaul docstrings & add SQLAlchemy to intersphinx mappings
bbe65e2 
Some of the stuff in `SopelDB` needed to reference SQLAlchemy docs, and
adding those intersphinx mappings was trivially easy, so it was done.
@dgw dgw merged commit 9a9ff64 into master Dec 21, 2019
@dgw dgw deleted the db-doc-overhaul branch December 21, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel