Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_updates: error handling #1779

Merged
merged 1 commit into from
Dec 9, 2019
Merged

find_updates: error handling #1779

merged 1 commit into from
Dec 9, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Dec 8, 2019

So I wrote this late one night, forgot to make a pull request for it, and here we are two weeks later. Maybe I held off making a PR, planning to come back and improve something first? Who knows.

Fixes #1643, at least in theory.

@dgw dgw added Low Priority Tweak Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Dec 8, 2019
@dgw dgw added this to the 7.0.0 milestone Dec 8, 2019
@dgw dgw requested a review from a team December 8, 2019 06:11
@dgw dgw force-pushed the updater-error-handling branch from 920746f to 354208e Compare December 8, 2019 06:18
@dgw
Copy link
Member Author

dgw commented Dec 8, 2019 •
edited
Loading

I forgot that JSONDecodeError isn't a normal built-in exception. 😟

Edit: And that JSONDecodeError doesn't exist until Python 3.5. 😡 (Third time's the charm?)

@dgw
find_updates: error handling
951fcca 
This turned out a bit messy, but I claim immunity from blame because
it's currently past 01:00 and too late for me to write clean code.
@dgw dgw force-pushed the updater-error-handling branch from 354208e to 951fcca Compare December 8, 2019 06:22
Exirel
Exirel approved these changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dgw dgw merged commit 684a848 into master Dec 9, 2019
@dgw dgw deleted the updater-error-handling branch December 9, 2019 23:49
@dgw dgw mentioned this pull request Apr 3, 2021
Closed
dgw added a commit that referenced this pull request Apr 3, 2021
@dgw
find_updates: return in ALL the appropriate failure cases
8dbce96 
Even if there haven't been enough check failures to trigger a warning to
Sopel's owner, it still needs to skip trying to print the `info` about
whatever new release is available because that variable doesn't exist.

Fixes #2051.

Missed in #1779 / 951fcca, oops.
@dgw dgw mentioned this pull request Apr 3, 2021
Merged
4 tasks
@RhinosF1 RhinosF1 mentioned this pull request Apr 3, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Low Priority Tweak
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

find_updates: No error handling on JSON fetch
2 participants
@dgw @Exirel