db: migrate to connectionless execution for raw sql #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
Bugfix
dgw
approved these changes
Dec 15, 2019
There was a problem hiding this comment.
Calling this High Priority because it fixes API backward-compatibility with how the db module worked before. Confirmed to fix the issue I had in my own plugin code (dgw/sopel-dgwmergeutils#12).
|
@RustyBower I ❤️ that you fixed this thing for me anyway, despite disagreeing with the feature, for the sake of API compatibility. Much appreciated! |
|
Yeah good work here @RustyBower For Sopel 7.1 we might want to reconsider how Sopel exposes its access to the DB into something different, but we'll see that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really hate being able to execute raw SQL against the database, but this should fix the issue for anyone needing to do it