-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup metadata overhaul #1787
Merged
Merged
Setup metadata overhaul #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaked the "long description" (though we might want PyPI to use the README file instead, not sure yet). Made myself the package author, since Embolalia hasn't expressed any interest whatsoever in staying involved, and everyone who built the projects leading up to Sopel is now credited in our CREDITS file. (The last thing I want is for Embo to get bothered by people emailing the "author" with support questions.) Added Python 3.8 to the project classifiers, since we do officially test on that version via Travis-CI.
Exirel
approved these changes
Dec 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good.
aa3b935
to
6fe32b1
Compare
And ignore the "annotations" future import
6fe32b1
to
30216b5
Compare
Re-requesting @Exirel's review of changes added by @half-duplex. |
Exirel
approved these changes
Jan 6, 2020
looks aight to me |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barring anything critical, this should be the last PR opened for 7.0.0. 🎉 Edit: Except the one with all the changelog (NEWS file) additions that I'll open when that's ready. Forgot we have a changelog. 😅
Any @sopel-irc/rockstars are welcome to review for typos/grammar, but I would like to get 👍 or 👎 from the repeat contributors I took the liberty of adding to CREDITS: @Exirel, @deathbybandaid, @RustyBower, @kwaaak, & @HumorBaby.
I'm happy to leave you off the list if you really want, or change the name shown there! I just want to recognize everyone who's been around for the long haul during the lead-up to 7.0. ❤️
Added mention respondents: