ip: update MaxMind GeoLite2 database fetching #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works with the changes introduced on December 30 (yesterday), which were announced literally the day before I left on an overseas trip for two weeks. Obviously, I didn't see the blog post before I left. I wrote this patch on a motorcoach in the middle of the desert. (Surprisingly, I was able to validate the fix and push the changes using the bus's Wi-Fi.) See the blog post from MaxMind for further details on why we have to make these silly changes (spoiler: it's because California sucks): https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
dgw
added
High Priority
Bugfix
half-duplex
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Works with the changes introduced on December 30 (yesterday), which were announced literally the day before I left on an overseas trip for two weeks. Obviously, I didn't see the blog post before I left. I wrote this patch on a motorcoach in the middle of the desert. (Surprisingly, I was able to validate the fix and push the changes using the bus's Wi-Fi.)
Resolves #1796
Checklist
make qa(runsmake qualityandmake test)make qualityis fine; Travis can report any issues in things I didn't touch when it's finished.