Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch version variable not being used in regex #1832

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Patch version variable not being used in regex #1832

merged 1 commit into from
Apr 11, 2020

Conversation

deathbybandaid
Copy link
Contributor

Description

This patches the _version_info function to ACTUALLY use the version variable passed to it in the regex match.

This should make the find_updates module do a better job checking that version < latest_version.

The current situation would always compare the local version to itself.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw changed the base branch from master to 7.0.x April 6, 2020 15:45
@dgw dgw added this to the 7.0.2 milestone Apr 6, 2020
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Apr 6, 2020
dgw
dgw approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this already approved? I swear I did. 😕

@dgw dgw merged commit 17f4cc6 into sopel-irc:7.0.x Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@deathbybandaid @dgw