tools.time: zero is a special case for seconds_to_human()

[dgw]

Patch looks big, but that's because Python doesn't have braces. 😏 (Just kidding, I'd update the indentation even if it did. I'm not a monster.)

Description

Fixes #1841.

Setup:

>>> from sopel.tools.time import seconds_to_human

Before:

>>> seconds_to_human(0)
' ago'

After:

>>> seconds_to_human(0)
'0 seconds ago'

Checklist

• I have read CONTRIBUTING.md
• I can and do license this contribution under the EFLv2
• No issues are reported by make qa (runs make quality and make test)
  • Caveats apply as with all my recent PRs: make quality is currently useless in my local environment
• I have tested the functionality of the things this change touches

[Exirel]

What about this instead?

if secs == 0:
    return 'just now'

[dgw]

@Exirel Yes in theory, but in practice it doesn't work in many of the places I and others are using this function. It's expected to give time units, and the language around it tends is often written in such a way that "just now" would be grammatically or syntactically wrong. Not sure what to do about those.

[Exirel]

the language around it tends is often written in such a way that "just now" would be grammatically or syntactically wrong

Then I'd say help yourself and make it a function's argument with a default value (I'm suggesting this "just now" but I don't have your use-case in mind, any default will be fine by me):

def fn(secs, right_now='just now'):
    if secs == 0:
        return right_now

    # here, you can do whatever you need to do when time isn't up

[dgw]

I'll have to think about that in relation to the other future ideas (#1798, #1799, #1824) for this function.

[Exirel]

That's only fair then. Let's keep my suggestion for later.