Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: cleanup dead stuff #1856

Merged
merged 1 commit into from
May 22, 2020
Merged

search: cleanup dead stuff #1856

merged 1 commit into from
May 22, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented May 6, 2020

Description

  • Remove unused formatnumber() function
  • Remove google_search alias to DuckDuckGo
  • Consolidate global "constants" at top of file

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
search: cleanup dead stuff
750e3f9 
* Remove unused `formatnumber()` function
* Remove `google_search` alias to DuckDuckGo
* Consolidate global "constants" at top of file
@dgw dgw added the Tweak label May 6, 2020
@dgw dgw added this to the 7.1.0 milestone May 6, 2020
@dgw dgw requested a review from a team May 6, 2020 12:22
@dgw
Copy link
Member Author

dgw commented May 6, 2020

Note: I considered marking the removed stuff as deprecated, but… really? This isn't public API.

@dgw dgw merged commit a3f5b31 into master May 22, 2020
@dgw dgw deleted the search-formatnumber-dead branch May 22, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel