Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: support SOPEL_CONFIG_DIR envvar to override --config-dir default #1900

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 27, 2020

Description

Really, it's just the one thing described in the PR title.

In hindsight, adding SOPEL_CONFIG and SOPEL_<SECTION>_<OPTION> support without also adding this seems kinda silly.

Draft for now because the tests haven't been updated yet. Hopefully I'll have a chance to talk to @Exirel on IRC tomorrow (my time; he's +7 hours from me), but there's also a review request in case he has any quick suggestions that don't need to wait for a synchronous chat opportunity. 😉

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

In hindsight, adding `SOPEL_CONFIG` and `SOPEL_<SECTION>_<OPTION>`
support without also adding this seems kinda silly.
@dgw dgw added the Feature label Jun 27, 2020
@dgw dgw added this to the 7.1.0 milestone Jun 27, 2020
@dgw dgw requested a review from Exirel June 27, 2020 23:01
@dgw dgw mentioned this pull request Jun 28, 2020
4 tasks
@dgw dgw marked this pull request as ready for review June 28, 2020 21:17
@dgw dgw requested review from a team and removed request for Exirel June 28, 2020 21:18
@dgw dgw merged commit 73e7230 into master Jul 3, 2020
@dgw dgw deleted the env-SOPEL_CONFIG_DIR branch July 3, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants