Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coretasks: replace module.label by plugin.label #1906

Merged
merged 1 commit into from
Jul 15, 2020
Merged

coretasks: replace module.label by plugin.label #1906

merged 1 commit into from
Jul 15, 2020

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jul 15, 2020

Description

This is a hotfix, this code should have been modified by #1898 and not merged with this error. My bad.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel
coretasks: replace module.label by plugin.label
82f343d 
This is a hotfix, this code should have been modified by sopel-irc#1898 and not
merged with this error. My bad.
@Exirel Exirel added High Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Jul 15, 2020
@Exirel Exirel requested a review from dgw July 15, 2020 14:01
@Exirel Exirel mentioned this pull request Jul 15, 2020
Merged
4 tasks
dgw
dgw approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, lol. :shipit:

@dgw dgw merged commit 4aea22c into sopel-irc:master Jul 15, 2020
@dgw dgw added this to the 7.1.0 milestone Jul 15, 2020
@Exirel Exirel deleted the coretasks-fix-plugin-label branch May 1, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) High Priority
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw