-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix/upgrade geoip2
requirements where possible
#1909
Conversation
Split `geoip2` requirement into ranges based on Python release. Capped `maxminddb` version on old Pythons now that v2.0 dropped them.
I'm aware that the build currently fails due to other test changes that need to be backported onto |
Yeah let's do this, it's great! |
The fields available in the GeoIP database are liable to change at any time, without warning. As long as the hostname looks fine and it belongs to the right AS, we don't really care about the extras, though.
We are not backporting the use of VCR to 7.0.x, so this example still needs to work without it.
Hello.
hoping that I can get help, on how to solve the problem, perhaps with a steep to steep explanation, because I'm not a lunux expert. Thank you so much. |
@mascalzone Temporary workaround: use Or await Sopel 7.0.5, which will include this patch (intended to fix the issue you're seeing) and should be out yet this weekend. |
sorry, please, I'm completely ignorant on linux. |
I gave pip install maxminddb
Sopel always starts with the ip module in error
|
SO MANY things have changed in Sopel since 6.0.9, I couldn't even begin to list them here. The changes in library versions between Ubuntu 16 and 18 are even greater. I must assume you've used If so, run Alternatively, Ubuntu 18 should have a new enough Python 3 release for you to use that instead and not get the error, with |
I did: pip3 install -e. |
Split
geoip2
requirement into ranges based on Python release.Capped
maxminddb
version on old Pythons now that v2.0 dropped them.Checklist
make qa
(runsmake quality
andmake test
)Notes
I'm planning to cut a 7.0.5 release with this unless any @sopel-irc/rockstars strenuously object. We're still too far off from finishing 7.1 to wait for that release. This is going to cause issues with new installs of 7.0.4.