ip: fix case sensitivity of querying by nickname #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivar-it
changed the title
dgw
changed the title
Fixes problem with .ip not working when uppercase letters in nick. The DB stores users in lowercase, so it does not get a match otherwise.
f0o
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes problem with .ip not working when uppercase letters in queried nick.
The DB stores users in lowercase, so it does not get a match otherwise.
Ex. when quering user "GLaDER"(hiding successful query output because privacy)
Found in 7.0.4, running in docker.
Currently not linked to any issue.
| .ip GLaDER
| I'm not aware of this user.
| .ip glader
| [IP/Host Lookup] Hostname: XXXX | Location: XXX| Region: XXXX | City: XXXX | ISP: XXXXX
Checklist
make qa(runsmake qualityandmake test)