wikipedia: implement language preferences in DB for channels & nicks #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
reviewed
Aug 3, 2020
If the DB does not contain any relevant settings for the calling nick or the channel in which the command was run, falls back to the existing `lang_per_channel` config value (if set), then `default_lang`.
The former `from sopel.module import ...` line was getting WAY too long when this PR was combined with more changes from `master` that happened while it was in flight.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the DB does not contain any relevant settings for the calling nick or the channel in which the command was run, falls back to the existing
lang_per_channelconfig value (if set), thendefault_lang.Note that the
lang_per_channelsetting is considered deprecated after this change. It has to stay defined in the section class (or it wouldn't be loaded), but it's been removed from everywhere possible and documented as deprecated in the code.Checklist
make qa(runsmake qualityandmake test)Notes
Upon merging this PR, update #827 to request removal of fallback to deprecated
lang_per_channelsetting for 8.0 milestone.