Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add space before attribute lists #1932

Merged
merged 1 commit into from
Sep 20, 2020
Merged

docs: add space before attribute lists #1932

merged 1 commit into from
Sep 20, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Sep 4, 2020

Description

Main motivation: Class/Module members/attributes were too close together in production docs. Finally got motivated to fix it.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

Might want to amend the commit/PR title if that spacing is the only tweak. Thinking I might find a few more before this is actually ready to go, but who knows? I might not.

@dgw dgw added this to the 7.1.0 milestone Sep 4, 2020
@dgw dgw requested a review from a team September 4, 2020 05:09
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (with nitpicking)

docs/source/_static/custom.css Show resolved Hide resolved
docs/source/_static/custom.css Show resolved Hide resolved
Class/Module members/attributes were too close together in production
docs. Finally got motivated to fix it with a silly little CSS trick.

Skips over lists that are first-of-type to avoid adding too much space
between section headings and attribute lists with no lede text.
@dgw dgw force-pushed the sphinx-css-tweaks branch from b8cd740 to 7a02493 Compare September 13, 2020 01:19
@dgw dgw changed the title docs: add some CSS tweaks to improve readability docs: add space before attribute lists Sep 13, 2020
@dgw dgw marked this pull request as ready for review September 13, 2020 01:19
@dgw
Copy link
Member Author

dgw commented Sep 13, 2020

I'd rather ship this than wait to collect more tweaks. Marked ready and reworded the commit message.

@dgw dgw merged commit fff8643 into master Sep 20, 2020
@dgw dgw deleted the sphinx-css-tweaks branch September 20, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants