tools: new SopelIdentifierMemory class
#1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
force-pushed
the
tools-memory-key-factory
branch
from
959db6f to
d451590
Compare
dgw
requested changes
Sep 23, 2020
There was a problem hiding this comment.
Those tests you added in tools have disabused me of any remaining notion that you're a humble man. 😛 Just one doc nitpick and a rebase. If you want to fix d451590's commit message so it capitalizes the new class name correctly, that's great too.
Exirel
force-pushed
the
tools-memory-key-factory
branch
from
b3ecb62 to
4374831
Compare
Exirel
force-pushed
the
tools-memory-key-factory
branch
from
4374831 to
8943564
Compare
dgw
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an attempt to fix #1341, I decided to create a new class that specifically deals with
tools.Identifieras its keys: nothing more, nothing less, justIdentifier.My idea is that we want
SopelMemoryto consider"nick"andIdentifier("nick")as two separated keys, and what we need is a specific type of memory, one that is specifically designed to store and retrieve values fromIdentifierkey. So that's what I did here.Checklist
make qa(runsmake qualityandmake test)