Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coretasks: reduce "useless MODE message" logspam #1951

Merged
merged 1 commit into from
Nov 6, 2020
Merged

coretasks: reduce "useless MODE message" logspam #1951

merged 1 commit into from
Nov 6, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 1, 2020

Description

This debug output is only relevant if the MODE message received pertains to a channel. We can stop emitting log entries for MODE messages that pertain to users only (target is a nick & has only 2 args).

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
coretasks: reduce "useless MODE message" logspam
6ca689f 
Check whether the MODE message target is a nick *first*, before checking
how many arguments it has. Problem solved.
@dgw dgw added the Tweak label Oct 1, 2020
@dgw dgw added this to the 7.1.0 milestone Oct 1, 2020
@dgw dgw requested a review from a team October 1, 2020 05:03
@dgw dgw merged commit 4c99079 into master Nov 6, 2020
@dgw dgw deleted the reduce-useless-mode-messages branch November 6, 2020 18:16
@dgw dgw mentioned this pull request Dec 25, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel