Path setting and doc tweaks; meetbot enforcement change #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied note about relative path behavior from `pid_dir` to both `logdir` and `ca_certs` docstrings. Added missing default-value annotations to `logdir` and `log_raw`, too, since I was already in the neighborhood.
In particular, added an example of `logdir` and `log_raw` usage, since I noticed those were missing when someone came to our IRC asking for help with raw logs not working (which turned out to be due to quotes).
Exirel
reviewed
Oct 8, 2020
|
Assuming @Exirel doesn't counter-argue my reasoning, I'll consider this a self-reminder to retitle the PR so it grabs my eye during changelog prep and I can add a courtesy notice about the |
Exirel
approved these changes
Oct 10, 2020
dgw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by that raw-logs-not-working problem someone brought to our IRC the other day, which turned out to be due to quotes in the config file, I decided to make some documentation adjustments.
I might have also tried to earn a few bonus points by making
meetbotenforce its own documented restriction on the meeting log path, which it said should be absolute but which it then allowed to be relative anyway.Checklist
make qa(runsmake qualityandmake test)